Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(domain): add announcement entity #474

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Conversation

siyeonSon
Copy link
Member

No description provided.

@siyeonSon siyeonSon added the 🥇asap As soon as possible label Jun 6, 2024
@Column(nullable = false)
private String title;

@Column(nullable = false, length = 255)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공지사항인데 Length가 너무 짧은 것 같습니다 ㅠ

Copy link
Member Author

@siyeonSon siyeonSon Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title 200자, content 3000자로 변경했습니다!

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.58%. Comparing base (fe88f7a) to head (fe50482).
Report is 7 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #474      +/-   ##
============================================
+ Coverage     30.12%   30.58%   +0.46%     
  Complexity      125      125              
============================================
  Files            77       76       -1     
  Lines           996      981      -15     
  Branches         32       31       -1     
============================================
  Hits            300      300              
+ Misses          691      676      -15     
  Partials          5        5              

see 1 file with indirect coverage changes

@siyeonSon
Copy link
Member Author

siyeonSon commented Jun 6, 2024

  • 업데이트/신규기능/버그수정/장애 등 여러가지 공지사항 타입으로 분류하면 좋을 것 같다고 생각했어요. 디자인이 나오기 전에는 최대한 단순한 형태로 도메인을 유지하는 게 좋을 것 같아서 Type 관련 컬럼은 추가하지 않았어요. 디자인이 나온 후에 필요하다면 반영하겠습니다.
  • 공지사항 등록 기능 개발 하시다가 공지사항에 사용될 이미지 테이블은 필요하시면 자유롭게 만들어 주세요! 개발을 어떤 식으로 하느냐에 따라 클래스 구조나 테이블 컬럼이 변경될 수 있을 것이라 생각해서 해당 PR에서는 추가하지 않았습니다.

@siyeonSon siyeonSon merged commit a80138d into dev Jun 6, 2024
2 checks passed
@siyeonSon siyeonSon deleted the feat/domain-announcement branch June 6, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥇asap As soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants